Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add allowed_view_extensions config node #48903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add allowed_view_extensions config node #48903

wants to merge 1 commit into from
+20 −3

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Oct 26, 2024 •
edited
Loading

Summary

It isn't possible to view jpg files if they were shared without allow downloading. Related to nextcloud/text#6564

🔍 Reproducer

Share file without download possibility

image

Try to view file as share recipient
image

To fix that we can introduce a new allowed_view_extensions config node.

  'allowed_view_extensions' => [
    'jpg',
    'jpeg',
    'png',
    // ...
  ]

TODO

  • ...

Checklist

@Koc Koc force-pushed the feature/add-allowed-view-extensions-config branch 2 times, most recently from 12dc126 to 532190a Compare October 26, 2024 13:49
@Koc Koc mentioned this pull request Oct 26, 2024
Open
5 tasks
@Koc Koc force-pushed the feature/add-allowed-view-extensions-config branch from 532190a to 806e116 Compare October 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin Awaiting requested review from provokateurin

@susnux susnux Awaiting requested review from susnux

@come-nc come-nc Awaiting requested review from come-nc

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Koc